fix: Array.mapIndexes stops on false literal#7441
Open
ElectricalBoy wants to merge 3 commits intomainfrom
Open
fix: Array.mapIndexes stops on false literal#7441ElectricalBoy wants to merge 3 commits intomainfrom
ElectricalBoy wants to merge 3 commits intomainfrom
Conversation
hjpalpha
approved these changes
Apr 29, 2026
Collaborator
|
Can you skim through and see if there's any usage that needs to be updated? I rather not have an infinite loop on our hands |
Collaborator
Author
all usages are okay from what I can tell |
Eetwalt
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lua-Modules/lua/wikis/commons/Array.lua
Lines 478 to 484 in 0958de2
The documentation for
Array.mapIndexesspecifies that it stops before the firstnilreturned byfunct. This is not true as the current implementation could also stop on afalseliteral being returned.This fixes the forementioned problem by explicitly checking for non-
nilreturn fromfunct.How did you test this change?
included test